next »

[walrus]

This should also work.

Code:

function load_xml_feed($location, &$title, &$link, &$description)
{

    $feedXml = simplexml_load_file($location);

    $i= ‘1′;
    foreach ($feedXml->channel->item as $article)
    {
        $title[$i] = (string)$article->title;
        $link[$i] = (string)$article->link;
        $description[$i] = (string)$article->description;
        $i++;
    }

    $randnumber = rand(2, $i);
    $link = trim($link[$randnumber]);
    $title = trim($title[$randnumber]);
    $description = trim($description[$randnumber]);
    $title = iconv(“UTF-8″, “ISO-8859-1″, $title);
    $description = iconv(“UTF-8″, “ISO-8859-1″, $description);
}

load_xml_feed($rss, $title, $link, $description);

[herbacious]

this is where OO coding starts to make a lot more sense

[perkiset]

Passing variables by reference is a well known and oft-used way of getting more than one return value from a function.

I must have missed this: was this thread originally about NEEDING more than one value returned from a function or a security hole? It looked to me like a surprised coder, rather than a question...

[nop_90]

@perks
he thought you could return 2 value from a function by going

return a; return b;

but his code was messed up, he had declared a & b globals, so it was a bug.

I then pointed out that for PHP, globals if not used correctly used to be a security problem (version < 4)
Or if it has make post and gets into a global turned on.

Either way very bad programming practice globals.

[perkiset]

Very bad indeed. As we've echoed, globals == bad. For the vast majority of situations.

[nutballs]

to sum up.

coder was surprised and apparently confused.
nutballs made it worse.
nutballs finally actually looked at the code again and saw the globals.
nutballs = idiot
move along.

[perkiset]